Make Pagination numerical by default #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit cdc3a6a): https://jac-admin-develop--pr2454-ts-242-stat-con-repo-wgvowlxo.web.app (expires Sun, 21 Jul 2024 16:34:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
drieJAC
reviewed
Jun 21, 2024
HalcyonJAC
requested changes
Jun 21, 2024
| @@ -156,7 +158,9 @@ export default { | |||
| where('status', 'in', statuses) | |||
| ); | |||
| params.orderBy = 'candidate.fullName'; | |||
| firestoreRef = await tableQuery(this.applicationRecords, firestoreRef, params); | |||
| const res = await tableAsyncQuery(this.applicationRecords, firestoreRef, params); | |||
There was a problem hiding this comment.
Could you pass null as the 4th parameter, please? It will be like:
const res = await tableAsyncQuery(this.applicationRecords, firestoreRef, params, null);
HalcyonJAC
approved these changes
Jun 24, 2024
drieJAC
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
do-over of old branch with merge issues.
Alphabetical pagination on the stat-con report page was causing confusion with the stat-con download.
I have made the pagination numerical by default so this page should always load any results, reducing confusion.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
visit stat con page (exercise >> reports >> statutory-consultation)
ensure pagination is numerical on initial load.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING